Conversation
closes #8541 Tests: Summary [ 149.522s] 469 tests run: 463 passed, 6 failed, 0 skipped FAIL [ 0.095s] naga::naga snapshots::convert_snapshots_spv FAIL [ 0.387s] wgpu-benchmark::bench/wgpu-benchmark Computepass Encoding FAIL [ 0.386s] wgpu-benchmark::bench/wgpu-benchmark Device::create_bind_group FAIL [ 0.378s] wgpu-benchmark::bench/wgpu-benchmark Device::create_buffer FAIL [ 0.389s] wgpu-benchmark::bench/wgpu-benchmark Renderpass Encoding FAIL [ 0.075s] wgpu-test::wgpu-validation api::instance::multi_instance::multi_instance
Contributor
Author
|
Apparently, I'm not allowed to push changes to the CI. |
Member
|
Why are you not allowed to push to CI? We don't have any such rule |
Contributor
Author
This might sound stupid but, I cannot push to my own fork. |
Contributor
Author
|
Ok, it looks like I might need to generate a new token with the necessary permissions, https://github.com/orgs/community/discussions/26254 Most probably I didn't think I would need this. |
Contributor
Author
|
I've looked around and I can't grasp what I need to do to fix this. Sorry about this. |
ErichDonGubler
added a commit
that referenced
this pull request
Jan 26, 2026
* Add basic NetBSD support - closes #8541 - replaces #8679 ``` Tests: Summary [ 149.522s] 469 tests run: 463 passed, 6 failed, 0 skipped FAIL [ 0.095s] naga::naga snapshots::convert_snapshots_spv FAIL [ 0.387s] wgpu-benchmark::bench/wgpu-benchmark Computepass Encoding FAIL [ 0.386s] wgpu-benchmark::bench/wgpu-benchmark Device::create_bind_group FAIL [ 0.378s] wgpu-benchmark::bench/wgpu-benchmark Device::create_buffer FAIL [ 0.389s] wgpu-benchmark::bench/wgpu-benchmark Renderpass Encoding FAIL [ 0.075s] wgpu-test::wgpu-validation api::instance::multi_instance::multi_instance ``` * Exclude Vulkan and DRM surface paths on NetBSD Match platform support and avoiding cfg mismatches between wgpu and wgpu-core. (with help from LLM) --------- Co-authored-by: Erich Gubler <erichdongubler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8541
Tests:
Summary [ 149.522s] 469 tests run: 463 passed, 6 failed, 0 skipped
FAIL [ 0.095s] naga::naga snapshots::convert_snapshots_spv
FAIL [ 0.387s] wgpu-benchmark::bench/wgpu-benchmark Computepass Encoding
FAIL [ 0.386s] wgpu-benchmark::bench/wgpu-benchmark Device::create_bind_group
FAIL [ 0.378s] wgpu-benchmark::bench/wgpu-benchmark Device::create_buffer
FAIL [ 0.389s] wgpu-benchmark::bench/wgpu-benchmark Renderpass Encoding
FAIL [ 0.075s] wgpu-test::wgpu-validation api::instance::multi_instance::multi_instance
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
When one pull request builds on another, please put "Depends on
#NNNN" towards the top of its description. This helps maintainers
notice that they shouldn't merge it until its ancestor has been
approved. Don't use draft PR status to indicate this.
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.
Squash or Rebase?
If your pull request contains multiple commits, please indicate whether
they need to be squashed into a single commit before they're merged,
or if they're ready to rebase onto
trunkas they stand. In thelatter case, please ensure that each commit passes all CI tests, so
that we can continue to bisect along
trunkto isolate bugs.Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.